[fixed] Please render magick.sh executable

Post any defects you find in the released or beta versions of the ImageMagick software here. Include the ImageMagick version, OS, and any command-line required to reproduce the problem. Got a patch for a bug? Post it here.
Post Reply
broucaries
Posts: 467
Joined: 2008-12-21T11:51:10-07:00

[fixed] Please render magick.sh executable

Post by broucaries »

Please render magick.sh executable.

Thanks
Last edited by broucaries on 2012-07-23T09:52:43-07:00, edited 1 time in total.
broucaries
Posts: 467
Joined: 2008-12-21T11:51:10-07:00

Re: Please render magick.sh executable

Post by broucaries »

something like AC_CONFIG_FILES([magick.sh], [chmod +x getObjectList]) instead of current one
User avatar
magick
Site Admin
Posts: 11064
Joined: 2003-05-31T11:32:55-07:00

Re: Please render magick.sh executable

Post by magick »

Thanks for the problem report. We added a patch in Subversion as you recommended.
broucaries
Posts: 467
Joined: 2008-12-21T11:51:10-07:00

Re: Please render magick.sh executable

Post by broucaries »

I have some patch for configure.ac BTW

And I plan to add some of your change to autoconf archive in order to limit your maintenance burden. Care to relicence configure.ac under all permissive licence ?

aka:
Copying and distribution of this file, with or without modification,
are permitted in any medium without royalty provided the copyright
notice and this notice are preserved.

patch 1

From e4ead1fb84869c00e9baff67200783eef01e496c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bastien=20ROUCARI=C3=88S?= <roucaries.bastien@gmail.com>
Date: Sun, 22 Jul 2012 17:05:54 +0200
Subject: [PATCH 1/2] Fix magick.sh

---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 9d7061d..096bbc7 100755
--- a/configure.ac
+++ b/configure.ac
@@ -51,7 +51,6 @@ AC_CONFIG_FILES([\
magick/MagickCore.pc \
magick/version.h \
Makefile \
- magick.sh \
PerlMagick/Magick.pm \
PerlMagick/Makefile.PL \
PerlMagick/check.sh \
@@ -71,6 +70,7 @@ AC_CONFIG_FILES([\
wand/MagickWand.pc \
wand/Wand-config \
wand/Wand.pc ])
+AC_CONFIG_FILES([magick.sh],[chmod +x magick.sh])

#
# Save initial user-tunable values
--
1.7.10
broucaries
Posts: 467
Joined: 2008-12-21T11:51:10-07:00

Re: Please render magick.sh executable

Post by broucaries »

From c002b0f743d47477ebdb52bd49413865eba9b479 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bastien=20ROUCARI=C3=88S?= <roucaries.bastien@gmail.com>
Date: Sun, 22 Jul 2012 17:18:00 +0200
Subject: [PATCH 2/2] use new ax_compiler_vendor

---
configure.ac | 2 +-
m4/ax_lang_compiler_ms.m4 | 37 -------------------------------------
2 files changed, 1 insertion(+), 38 deletions(-)
delete mode 100644 m4/ax_lang_compiler_ms.m4

diff --git a/configure.ac b/configure.ac
index 096bbc7..05eb4f7 100755
--- a/configure.ac
+++ b/configure.ac
@@ -260,6 +260,7 @@ AC_SUBST(LD)
AC_PROG_CC_C99
AM_PROG_CC_C_O
AX_CFLAGS_WARN_ALL
+AX_COMPILER_VENDOR
AC_PROG_INSTALL
AC_PROG_MAKE_SET
AC_PROG_LN_S
@@ -287,7 +288,6 @@ fi
#
AC_EXEEXT
AC_OBJEXT
-AX_LANG_COMPILER_MS

GDI32_LIBS=''
native_win32_build='no'
diff --git a/m4/ax_lang_compiler_ms.m4 b/m4/ax_lang_compiler_ms.m4
deleted file mode 100644
index 658ca85..0000000
--- a/m4/ax_lang_compiler_ms.m4
+++ /dev/null
@@ -1,37 +0,0 @@
-# ===========================================================================
-# http://www.gnu.org/software/autoconf-ar ... er_ms.html
-# ===========================================================================
-#
-# SYNOPSIS
-#
-# AX_LANG_COMPILER_MS
-#
-# DESCRIPTION
-#
-# Check whether the compiler for the current language is Microsoft.
-#
-# This macro is modeled after _AC_LANG_COMPILER_GNU in the GNU Autoconf
-# implementation.
-#
-# LICENSE
-#
-# Copyright (c) 2009 Braden McDaniel <braden@endoframe.com>
-#
-# Copying and distribution of this file, with or without modification, are
-# permitted in any medium without royalty provided the copyright notice
-# and this notice are preserved. This file is offered as-is, without any
-# warranty.
-
-#serial 8
-
-AC_DEFUN([AX_LANG_COMPILER_MS],
-[AC_CACHE_CHECK([whether we are using the Microsoft _AC_LANG compiler],
- [ax_cv_[]_AC_LANG_ABBREV[]_compiler_ms],
-[AC_COMPILE_IFELSE([AC_LANG_PROGRAM([], [[#ifndef _MSC_VER
- choke me
-#endif
-]])],
- [ax_compiler_ms=yes],
- [ax_compiler_ms=no])
-ax_cv_[]_AC_LANG_ABBREV[]_compiler_ms=$ax_compiler_ms
-])])
--
1.7.10
User avatar
magick
Site Admin
Posts: 11064
Joined: 2003-05-31T11:32:55-07:00

Re: [fixed] Please render magick.sh executable

Post by magick »

Added the permissive license as requested and made the mods you recommended. It will be a few hours before the changes appear in Subversion.
Post Reply