Recurring test-failures -- most annoying

[mi]

Code: Select all

perl t/filter.t
...
Modulate(brightness=>110,saturation=>110,hue=>110) ...
  mean-error=0,00462525641117487, maximum-error=0,298039215686275
not ok 31
...

I'm certain, this is just another one of those "Oh, it's Ok, just bump the tolerance up a bit" kind of things.

What's annoying is that the test includes the maximum error ever observed by the developers, instead of the maximum acceptable value for the tolerance...

[magick]

The problem you reported is fixed in ImageMagick 6.3.6-5 Beta. Thanks.

[mi]

The problem you reported is fixed in ImageMagick 6.3.6-5 Beta. Thanks.

Could I have a patch meanwhile, please? Thanks!

[magick]

in PerlMagick/t/filter.t, change 0.004 to 0.005:

• testFilterCompare('input.miff', q//, 'reference/filter/Modulate.miff', 'Modulate', q/brightness=>110,saturation=>110,hue=>110/, 0.005, 0.4);

We keep the tolerance tight because we are testing a new resampling algorithm and we need to know if any variation is introduced by expected floating point error or a problem within the algorithm.